-
Notifications
You must be signed in to change notification settings - Fork 151
Introduce Bookmark Manager #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
166df47
to
30785e5
Compare
30785e5
to
2e4bf21
Compare
robsdedude
reviewed
Aug 18, 2022
robsdedude
reviewed
Aug 19, 2022
robsdedude
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔖
d09bbd9
to
8575825
Compare
fbiville
approved these changes
Aug 31, 2022
0726ae4
to
7af8730
Compare
fbiville
approved these changes
Sep 1, 2022
robsdedude
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⏱️
robsdedude
reviewed
Sep 1, 2022
Depends on: neo4j-drivers/testkit#513 |
Removing update bm on acquiring connection This reverts commit fc8837e.
This changes also includes concatenate session bookmarks and manager bookmarks
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
177e5d0
to
28cd7cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neo4j clusters are causally consistent, meaning that by default there is no guarantee a query will be able to read changes made by a previous query. For cases where such a guarantee is necessary, the server provides bookmarks to the client. A bookmark is an abstract token that represents some state of the database. By passing one or multiple bookmarks along with a query, the server will make sure that the query will not get executed before the represented state(s) (or a later state) have been established.
The bookmark manager is an interface used by the driver for keeping track of the bookmarks and this way keeping sessions automatically consistent.
Usage in the session
Enabling it is done by supplying an BookmarkManager implementation instance to this param.
A default implementation could be acquired by calling the factory function
neo4j.bookmarkManager()
.Warning: Share the same BookmarkManager instance across all session can have a negative impact
on performance since all the queries will wait for the latest changes being propagated across the cluster.
For keeping consistency between a group of queries, use
Session
for grouping them.For keeping consistency between a group of sessions, use
BookmarkManager
instance for grouping them.